Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755577AbYFIQjS (ORCPT ); Mon, 9 Jun 2008 12:39:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752618AbYFIQjI (ORCPT ); Mon, 9 Jun 2008 12:39:08 -0400 Received: from sj-iport-1.cisco.com ([171.71.176.70]:25537 "EHLO sj-iport-1.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbYFIQjG (ORCPT ); Mon, 9 Jun 2008 12:39:06 -0400 X-IronPort-AV: E=Sophos;i="4.27,613,1204531200"; d="scan'208";a="39710444" From: Roland Dreier To: Stefan Roscher Cc: Roland Dreier , "OF-EWG" , general@lists.openfabrics.org, LKML , "LinuxPPC-Dev" , hnguyen@de.ibm.com, fenkes@de.ibm.com, raisch@de.ibm.com, TKLEIN@de.ibm.com, THEMANN@de.ibm.com Subject: Re: [PATCH 2/2] IB/ehca: In case of lost interrupts, trigger EOI to reenable interrupts References: <200806091745.19147.ossrosch@linux.vnet.ibm.com> X-Message-Flag: Warning: May contain useful information Date: Mon, 09 Jun 2008 09:38:59 -0700 In-Reply-To: <200806091745.19147.ossrosch@linux.vnet.ibm.com> (Stefan Roscher's message of "Mon, 9 Jun 2008 17:45:17 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 09 Jun 2008 16:39:00.0160 (UTC) FILETIME=[51AD5400:01C8CA4F] Authentication-Results: sj-dkim-2; header.From=rdreier@cisco.com; dkim=pass ( sig from cisco.com/sjdkim2002 verified; ); Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 502 Lines: 13 > + if (desc->chip && desc->chip->eoi) > + desc->chip->eoi(irq); This doesn't seem like the type of thing a device driver should be doing. Both patches are rather short on changelog text -- what is the issue here and how does this fix it? - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/