From: Roland Dreier <rdreier@cisco.com>
To: Stefan Roscher <ossrosch@linux.vnet.ibm.com>
Cc: Roland Dreier <rolandd@cisco.com>, "OF-EWG" <ewg@lists.openfabrics.org>,
       general@lists.openfabrics.org, LKML <linux-kernel@vger.kernel.org>,
       "LinuxPPC-Dev" <linuxppc-dev@ozlabs.org>, hnguyen@de.ibm.com,
       fenkes@de.ibm.com, raisch@de.ibm.com, TKLEIN@de.ibm.com,
       THEMANN@de.ibm.com
Subject: Re: [PATCH 2/2] IB/ehca: In case of lost interrupts, trigger EOI to reenable interrupts
References: <200806091745.19147.ossrosch@linux.vnet.ibm.com>
Date: Mon, 09 Jun 2008 09:38:59 -0700
In-Reply-To: <200806091745.19147.ossrosch@linux.vnet.ibm.com> (Stefan
	Roscher's message of "Mon, 9 Jun 2008 17:45:17 +0200")
Message-ID: <adatzg28sws.fsf@cisco.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 502
Lines: 13

 > +				if (desc->chip && desc->chip->eoi)
 > +					desc->chip->eoi(irq);

This doesn't seem like the type of thing a device driver should be
doing.  Both patches are rather short on changelog text -- what is the
issue here and how does this fix it?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/