Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757640AbYFIRRv (ORCPT ); Mon, 9 Jun 2008 13:17:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752834AbYFIRRk (ORCPT ); Mon, 9 Jun 2008 13:17:40 -0400 Received: from sous-sol.org ([216.99.217.87]:46248 "EHLO sous-sol.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755570AbYFIRRW (ORCPT ); Mon, 9 Jun 2008 13:17:22 -0400 Date: Mon, 9 Jun 2008 10:08:40 -0700 From: Chris Wright To: "H. Peter Anvin" Cc: Chris Wright , Marcin Krol , jejb@kernel.org, "Theodore Ts'o" , Zwane Mwaikambo , torvalds@linux-foundation.org, Justin Forbes , linux-kernel@vger.kernel.org, Chris Wedgwood , Domenico Andreoli , Nick Piggin , Randy Dunlap , Michael Krufky , Chuck Ebbert , Dave Jones , akpm@linux-foundation.org, Chuck Wolber , stable@kernel.org, alan@lxorguk.ukuu.org.uk Subject: Re: [stable] [patch 21/50] brd: dont show ramdisks in /proc/partitions Message-ID: <20080609170840.GG30402@sequoia.sous-sol.org> References: <20080607010215.358296706@sous-sol.org> <20080607010610.796754560@sous-sol.org> <484B02CF.6000606@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <484B02CF.6000606@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 22 * H. Peter Anvin (hpa@kernel.org) wrote: > This seems a bit like cargo cult programming to me. If there isn't a > known, good, reason to revert this behaviour change, I would consider it > a bugfix, not a regression. We have one /proc/partitions parser that got broken (never saw details on how). I don't care for this change either (esp. since nbd is still left out...it's inconsistent). This is now the upstream behaviour (obvious since it's a -stable candidate), and the change was introduced in 2.6.25...I'd actually prefer to drop this patch, but there's no good reason to deviate if upstream keeps this one. I can defer while upstream gets revisited, can you revisit this upstream? thanks, -chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/