Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758722AbYFISUJ (ORCPT ); Mon, 9 Jun 2008 14:20:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750728AbYFIST6 (ORCPT ); Mon, 9 Jun 2008 14:19:58 -0400 Received: from kirk.serum.com.pl ([213.77.9.205]:63277 "EHLO serum.com.pl" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754171AbYFIST5 (ORCPT ); Mon, 9 Jun 2008 14:19:57 -0400 Date: Mon, 9 Jun 2008 19:18:52 +0100 (BST) From: "Maciej W. Rozycki" To: Roman Zippel cc: Andrew Morton , Thomas Gleixner , Alessandro Zummo , linux-kernel@vger.kernel.org Subject: Re: [PATCH] NTP: Let update_persistent_clock() sleep In-Reply-To: Message-ID: References: <20080528201612.d2641dc3.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1088 Lines: 25 Hi, > > Roman does most of the NTP work afaik. I consider Thomas's git-hrt > > tree to be the route via which NTP changes get into linux-next and > > mainline. > > That function is a little misplaced, we already have a driver/rtc dir, > where this should go in the long term and ntp.c only providing the > trigger, that time is stable. There it would also be possible to better > take into account any quirks needed to update the chip. I posted a separate change to implement a backend using the RTC class device. I think this is the right solution till all the platforms are moved away from legacy RTC drivers. I think you are right about the long-term implications and apart from any possible quirks I think the interface could get improved as there are RTC chips we support nowadays that provide sub-second resolution. Maciej -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/