Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755089AbYFIUxg (ORCPT ); Mon, 9 Jun 2008 16:53:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752372AbYFIUx1 (ORCPT ); Mon, 9 Jun 2008 16:53:27 -0400 Received: from rv-out-0506.google.com ([209.85.198.230]:17399 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbYFIUxZ (ORCPT ); Mon, 9 Jun 2008 16:53:25 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=EYvqSk2+jfSu6jLAvV8o29++Tg1PnP5TrFK1GgrhrwUPNnC2IJYydZOJcCrYxKxz0s 0F8RyOCGrDFKa/5kUAFgFENBpeOGca3TKdNVQqUBLaA9zqq52Doi70dB11t6hldV4d1+ UyUvAa3y+kKjMRqD/qJObGM13UKM1vnFWO1ek= Message-ID: <86802c440806091353m240ab7adocbaf5dacd15504f7@mail.gmail.com> Date: Mon, 9 Jun 2008 13:53:24 -0700 From: "Yinghai Lu" To: "Maciej W. Rozycki" Subject: Re: [PATCH 11/15] x86: move enabling of io_apic to prepare_cpus Cc: "Glauber Costa" , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tglx@linutronix.de, mingo@elte.hu, hugh@veritas.com In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1213021018-14159-1-git-send-email-gcosta@redhat.com> <1213021018-14159-7-git-send-email-gcosta@redhat.com> <1213021018-14159-8-git-send-email-gcosta@redhat.com> <1213021018-14159-9-git-send-email-gcosta@redhat.com> <1213021018-14159-10-git-send-email-gcosta@redhat.com> <1213021018-14159-11-git-send-email-gcosta@redhat.com> <1213021018-14159-12-git-send-email-gcosta@redhat.com> <484D8813.4040807@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1041 Lines: 25 On Mon, Jun 9, 2008 at 1:12 PM, Maciej W. Rozycki wrote: > On Mon, 9 Jun 2008, Glauber Costa wrote: > >> This one does enable_IO_APIC in the init_uniprocessor too, and should >> account for the !smp case. > > Hmm, it looks a little bit better, but why do you want to call > enable_IO_APIC() separately in the first place? There is a comment > stating: "Enable IO APIC before setting up error vector," but why is it > needed on 64-bit systems? Especially as the very same system may run a > 32-bit kernel and then it suddenly would not have to do this anymore? > Strange... that enable_IO_APIC() only call record old ioapic/pin for timer and clear_IO_APIC. we need clear_IO_APIC before enable setup error vector, in case there is wrong setting in ioapic by BIOS... YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/