Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756554AbYFIUyu (ORCPT ); Mon, 9 Jun 2008 16:54:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752599AbYFIUyl (ORCPT ); Mon, 9 Jun 2008 16:54:41 -0400 Received: from mx1.redhat.com ([66.187.233.31]:53385 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285AbYFIUyk (ORCPT ); Mon, 9 Jun 2008 16:54:40 -0400 Date: Mon, 9 Jun 2008 16:54:29 -0400 From: Vivek Goyal To: Bernhard Walle Cc: Amul Shah , Andi Kleen , Johannes Weiner , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, hpa@zytor.com, anderson@redhat.com, "Romer, Benjamin M" Subject: Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic() Message-ID: <20080609205429.GJ3542@redhat.com> References: <20080608134628.757299158@halley.suse.de> <20080608134629.743220278@halley.suse.de> <87bq2bmvro.fsf@saeurebad.de> <20080609132207.GC3542@redhat.com> <20080609182341.00d6e746@halley.suse.de> <484D5CCB.5020709@firstfloor.org> <1213041041.19111.68.camel@ustr-shaha1-linux-dev.na.uis.unisys.com> <20080609221732.1e14e5d5@kopernikus.site> <20080609202935.GI3542@redhat.com> <20080609224211.2ef0f74c@kopernikus.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080609224211.2ef0f74c@kopernikus.site> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 27 On Mon, Jun 09, 2008 at 10:42:11PM +0200, Bernhard Walle wrote: > Hi Vivek, > > * Vivek Goyal [2008-06-09 16:29]: > > > > Can you please put some more explanation comment here to explain that > > why it is ok to return with success, despite the fact that we never > > reserved any memory. > > Do you think that's ok? > > When booting the kdump kernel, the MP tables (for example, > or other firmware-reserved memory) of the BIOS are beyond > end_pfn. (kexec-tools adds exactmap parameters to the kernel > so that the E820 map is no longer used.) Therefore, it's ok > to return "success" here. For normal boot, the MP tables > must be reserved normally. > Looks good. Thanks Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/