Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760973AbYFIVY0 (ORCPT ); Mon, 9 Jun 2008 17:24:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759629AbYFIVYF (ORCPT ); Mon, 9 Jun 2008 17:24:05 -0400 Received: from tim.rpsys.net ([194.106.48.114]:60841 "EHLO tim.rpsys.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754695AbYFIVYB (ORCPT ); Mon, 9 Jun 2008 17:24:01 -0400 X-Greylist: delayed 1456 seconds by postgrey-1.27 at vger.kernel.org; Mon, 09 Jun 2008 17:23:56 EDT Subject: Re: [patch 4/5] sparse: leds-h1940.c: make non-exported symbols static From: Richard Purdie To: Ben Dooks Cc: Linux ARM Kernel , Linux Kernel , Arnaud Patard In-Reply-To: <20080607153712.202340716@fluff.org.uk> References: <20080607153655.026170849@fluff.org.uk> <20080607153712.202340716@fluff.org.uk> Content-Type: text/plain Date: Mon, 09 Jun 2008 22:02:47 +0100 Message-Id: <1213045367.5026.66.camel@dax.rpnet.com> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 25 On Sat, 2008-06-07 at 16:36 +0100, Ben Dooks wrote: > plain text document attachment (sparse-fix-h1940-leds.patch) > We do not need to export any of the routines inside > drivers/leds/leds-h1940.c, so make them all static to > quieten the sparse output for this driver. > > Fixes the following sparse errors: > drivers/leds/leds-h1940.c:26:6: warning: symbol 'h1940_greenled_set' was not declared. Should it be static? > drivers/leds/leds-h1940.c:55:6: warning: symbol 'h1940_redled_set' was not declared. Should it be static? > drivers/leds/leds-h1940.c:85:6: warning: symbol 'h1940_blueled_set' was not declared. Should it be static? > > CC: Richard Purdie > CC: Linux Kernel > CC: Arnaud Patard > Signed-off-by: Ben Dooks Queued in the LEDs tree, thanks. Richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/