Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755894AbYFJNGO (ORCPT ); Tue, 10 Jun 2008 09:06:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753257AbYFJNF6 (ORCPT ); Tue, 10 Jun 2008 09:05:58 -0400 Received: from mx1.redhat.com ([66.187.233.31]:36418 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753209AbYFJNF5 (ORCPT ); Tue, 10 Jun 2008 09:05:57 -0400 Message-ID: <484E7B03.8000604@redhat.com> Date: Tue, 10 Jun 2008 10:00:51 -0300 From: Glauber Costa Organization: Red Hat User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Yinghai Lu CC: "Maciej W. Rozycki" , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tglx@linutronix.de, mingo@elte.hu, hugh@veritas.com Subject: Re: [PATCH 11/15] x86: move enabling of io_apic to prepare_cpus References: <1213021018-14159-1-git-send-email-gcosta@redhat.com> <1213021018-14159-10-git-send-email-gcosta@redhat.com> <1213021018-14159-11-git-send-email-gcosta@redhat.com> <1213021018-14159-12-git-send-email-gcosta@redhat.com> <484D8813.4040807@redhat.com> <86802c440806091353m240ab7adocbaf5dacd15504f7@mail.gmail.com> <86802c440806092208s338cf6b6q892f5149bbd142ca@mail.gmail.com> In-Reply-To: <86802c440806092208s338cf6b6q892f5149bbd142ca@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1183 Lines: 31 Yinghai Lu wrote: > On Mon, Jun 9, 2008 at 7:46 PM, Maciej W. Rozycki wrote: >> On Mon, 9 Jun 2008, Maciej W. Rozycki wrote: >> >>>> we need clear_IO_APIC before enable setup error vector, in case there >>>> is wrong setting in ioapic by BIOS... >>> Fair enough, although it is still interesting why it would only trigger >>> in the 64-bit mode and why shouldn't the BIOS be fixed instead. >> Then again -- what if X86_LOCAL_APIC is set, but X86_IO_APIC is not? > > config X86_LOCAL_APIC > def_bool y > depends on X86_64 || (X86_32 && (X86_UP_APIC || ((X86_VISWS || > SMP) && !X86_VOYAGER) || X86_GENERICARCH)) > > config X86_IO_APIC > def_bool y > depends on X86_64 || (X86_32 && (X86_UP_IOAPIC || (SMP && > !(X86_VISWS || X86_VOYAGER)) || X86_GENERICARCH)) > > for 64bit, those are all set. > > for 32bit, may need to null stub if X86_IO_APIC is not set > > YH Fair Enough. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/