Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755218AbYFJQha (ORCPT ); Tue, 10 Jun 2008 12:37:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752754AbYFJQhR (ORCPT ); Tue, 10 Jun 2008 12:37:17 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51578 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752254AbYFJQhP (ORCPT ); Tue, 10 Jun 2008 12:37:15 -0400 Date: Tue, 10 Jun 2008 09:36:08 -0700 (PDT) From: Linus Torvalds To: Oliver Neukum cc: Pavel Machek , linux-usb@vger.kernel.org, Greg KH , Alan Stern , Linus Torvalds , Andrew Morton , kernel list , "Rafael J. Wysocki" Subject: Re: 2.6.25-rc6: CONFIG_USB_PERSIST forced on In-Reply-To: Message-ID: References: <200806091712.46869.oliver@neukum.org> <20080609215651.GF21429@elf.ucw.cz> <200806101055.14539.oliver@neukum.org> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 24 On Tue, 10 Jun 2008, Linus Torvalds wrote: > + > + intf = actconfig->interface[i]; > + driver = to_usb_driver(intf->dev.driver); > + if (!driver) > + continue; This is wrong. It should be if (!intf->dev.driver) continue; driver = to_usb_driver(intf->dev.driver); because doing the check after the "to_usb_driver()" conversion is too late. I copied the bug from Oliver's version. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/