Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755715AbYFJRdk (ORCPT ); Tue, 10 Jun 2008 13:33:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752621AbYFJRda (ORCPT ); Tue, 10 Jun 2008 13:33:30 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:50796 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752331AbYFJRda (ORCPT ); Tue, 10 Jun 2008 13:33:30 -0400 Date: Tue, 10 Jun 2008 10:33:29 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Mike Travis cc: Eric Dumazet , akpm@linux-foundation.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, David Miller , Peter Zijlstra , Rusty Russell Subject: Re: [patch 02/41] cpu alloc: The allocator In-Reply-To: <4846AD84.2090800@sgi.com> Message-ID: References: <20080530035620.587204923@sgi.com> <20080530040011.084909898@sgi.com> <483F8AF7.9000309@cosmosbay.com> <4846AD84.2090800@sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 23 On Wed, 4 Jun 2008, Mike Travis wrote: > I'm a bit confused. Why is DEFINE_PER_CPU_SHARED_ALIGNED() conditioned on > ifdef MODULE? > > #ifdef MODULE > #define SHARED_ALIGNED_SECTION ".data.percpu" > #else > #define SHARED_ALIGNED_SECTION ".data.percpu.shared_aligned" > #endif > > #define DEFINE_PER_CPU_SHARED_ALIGNED(type, name) \ > __attribute__((__section__(SHARED_ALIGNED_SECTION))) \ > PER_CPU_ATTRIBUTES __typeof__(type) per_cpu__##name \ > ____cacheline_aligned_in_smp Looks wrong to me. There can be shared objects even without modules. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/