Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757473AbYFJWj5 (ORCPT ); Tue, 10 Jun 2008 18:39:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753462AbYFJWjn (ORCPT ); Tue, 10 Jun 2008 18:39:43 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:40370 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753375AbYFJWjm (ORCPT ); Tue, 10 Jun 2008 18:39:42 -0400 Message-ID: <484F02A0.7010009@garzik.org> Date: Tue, 10 Jun 2008 18:39:28 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Jay Vosburgh CC: Nicolas 2P , David Miller , bonding-devel@lists.sourceforge.net, linux-net@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [patch] bondig - arp_interval with low value => Oops. References: <482C9E73.2040202@free.fr> <484EFDFC.3040206@garzik.org> <8135.1213137006@death> In-Reply-To: <8135.1213137006@death> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.4 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1182 Lines: 35 Jay Vosburgh wrote: > Jeff Garzik wrote: > >> Nicolas 2P wrote: >>> When setting arp_interval parameter to a very low value, delta_in_ticks >>> for next arp might become 0, causing an infinite loop. >>> >>> See http://bugzilla.kernel.org/show_bug.cgi?id=10680 >>> >>> Same problem for miimon parameter already fixed, but fix might be >>> enhanced, by using msecs_to_jiffies() function. >>> >>> Signed-off-by: Nicolas de Pesloüan >> I don't see an ACK from Jay in my mbox? >> >> Certainly looks nicer than adding "? : 1" to each of the remaining two >> cases. > > This was accepted a couple of weeks ago; I had to fix a bug in > the patch, so I'd guess you didn't connect them: > > commit 5ce0da8f0386b62345312ec8fed31303732f4220 > Author: Jay Vosburgh > Date: Sat May 17 21:10:07 2008 -0700 > > bonding: Use msecs_to_jiffies, eliminate panic Great, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/