Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 16 Jan 2002 05:35:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 16 Jan 2002 05:34:51 -0500 Received: from oflmta01bw.bigpond.com ([139.134.6.21]:20204 "EHLO oflmta01bw.bigpond.com") by vger.kernel.org with ESMTP id ; Wed, 16 Jan 2002 05:34:32 -0500 From: Rusty Russell To: Ingo Molnar Cc: linux-kernel , Linus Torvalds Subject: Re: [PATCH] I3 sched tweaks... In-Reply-To: Your message of "Wed, 16 Jan 2002 04:15:47 CDT." Date: Wed, 16 Jan 2002 21:34:39 +1100 Message-Id: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org In message you write: > > 4) scheduler_tick needs no args (p is always equal to current). > > i have not taken this part. We have 'current' calculated in > update_process_times(), so why not pass it along to the scheduler_tick() > function? Because it's redundant. It's *always* p == current (and the code assumes this!), but I had to grep the callers to find out. Moreover, the function doesn't make *sense* if p != current... > > 3) lock_task_rq returns the rq, rather than assigning it, for clarity. > > i've made it an inline function instead of a macro. I thought of that, but assumed you had a good reason for making it a macro in the first place... Thanks! Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/