Subject: Re: [PATCH 3/5] mutex debug: add generic blocked_on usage
From: Daniel Walker <dwalker@mvista.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ulrich Drepper <drepper@gmail.com>,
       Thomas Gleixner <tglx@linutronix.de>,
       Arjan van de Ven <arjan@infradead.org>
In-Reply-To: <1213248327.31518.77.camel@twins>
References: <20080611204916.271608740@mvista.com>
	 <20080611204917.267412694@mvista.com>  <1213248327.31518.77.camel@twins>
Content-Type: text/plain
Date: Thu, 12 Jun 2008 06:21:31 -0700
Message-Id: <1213276891.16459.14.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1027
Lines: 32


On Thu, 2008-06-12 at 07:25 +0200, Peter Zijlstra wrote:
> On Wed, 2008-06-11 at 13:49 -0700, Daniel Walker wrote:
> > plain text document attachment (blocked_on-mutex.patch)
> 
> > -#ifdef CONFIG_DEBUG_MUTEXES
> > -	/* mutex deadlock detection */
> > -	struct mutex_waiter *blocked_on;
> > -#endif
> > +	/*
> > +	 * Deadlock detection and priority inheritance handling,
> > +	 * and any other out of line mutex operations
> > +	 */
> > +	struct lock_waiter_state *blocked_on;
> 
> Now you grew task_struct unconditionally, how about
> 
> #if defined CONFIG_DEBUG_MUTEX || defined CONFIG_RT_MUTEXES || defined CONFIG_FUTEX
> 
> ?

Ok .. I didn't add it cause I wasn't convinced RT_MUTEXES was
optional .. There's a lot of PI futex related code that isn't ifdef'd
either..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/