Subject: Re: [PATCH] [RESEND] fix HID quirks for aluminium apple wireless
	keyboards
From: Marcel Holtmann <marcel@holtmann.org>
To: Paul Collins <paul@burly.ondioline.org>
Cc: jkosina@suse.cz, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
       linux-usb@vger.kernel.org
In-Reply-To: <874p7ylsj0.fsf@burly.wgtn.ondioline.org>
References: <87iqweltzo.fsf@burly.wgtn.ondioline.org>
	 <874p7ylsj0.fsf@burly.wgtn.ondioline.org>
Content-Type: text/plain
Date: Thu, 12 Jun 2008 22:08:09 +0200
Message-Id: <1213301289.17870.72.camel@violet.holtmann.net>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 846
Lines: 24

Hi Paul,

> I noticed that the quirks for Bluetooth Apple keyboards seem to have
> been incorrectly added to the USB HID, thus rendering them ineffective.
> Here is a patch that moves them to the Bluetooth HID.  With this patch
> applied the Fn key on my Apple wireless keyboard now works as expected.
> 
> I also took the liberty of adding defines for the vendor and for the
> existing Mighty Mouse quirk.

I prefer not to do this. I don't see any benefit or readability coming
out of it. Leave it as it is. Add the numeric ids and then a line on top
of it describing the devices.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/