Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759317AbYFMNux (ORCPT ); Fri, 13 Jun 2008 09:50:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755708AbYFMNun (ORCPT ); Fri, 13 Jun 2008 09:50:43 -0400 Received: from mx1.redhat.com ([66.187.233.31]:44452 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755216AbYFMNum (ORCPT ); Fri, 13 Jun 2008 09:50:42 -0400 Subject: Re: [PATCH] firewire: fw-ohci: write selfIDBufferPtr before LinkControl.rcvSelfID From: Kristian =?ISO-8859-1?Q?H=F8gsberg?= To: Stefan Richter Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org In-Reply-To: References: Content-Type: text/plain; charset=utf8 Date: Fri, 13 Jun 2008 09:50:14 -0400 Message-Id: <1213365014.15164.38.camel@gaara.bos.redhat.com> Mime-Version: 1.0 X-Mailer: Evolution 2.22.0 (2.22.0-4.fc9) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 20 On Thu, 2008-06-05 at 20:50 +0200, Stefan Richter wrote: > OHCI 1.1 clause 5.10 requires that selfIDBufferPtr is valid when a 1 is > written into LinkControl.rcvSelfID. > > This driver bug has so far not been known to cause harm because most > chips obviously accept a later selfIDBufferPtr write. > > Signed-off-by: Stefan Richter Yeah, good point. I think it also caused no harm because we set it up before enabling the link. But your change definitely looks good. Signed-off-by: Kristian Høgsberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/