Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762626AbYFNAQj (ORCPT ); Fri, 13 Jun 2008 20:16:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760158AbYFNANG (ORCPT ); Fri, 13 Jun 2008 20:13:06 -0400 Received: from mx1.suse.de ([195.135.220.2]:34239 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759049AbYFNANF (ORCPT ); Fri, 13 Jun 2008 20:13:05 -0400 Date: Fri, 13 Jun 2008 17:10:49 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , Willy Tarreau , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, "David S. Miller" , Chris Wright Subject: [patch 13/47] sunhv: Fix locking in non-paged I/O case. Message-ID: <20080614001049.GM24698@suse.de> References: <20080613234753.235721454@mini.kroah.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="sunhv-fix-locking-in-non-paged-i-o-case.patch" In-Reply-To: <20080614000840.GA24659@suse.de> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 33 -stable review patch. If anyone has any objections, please let us know. ------------------ From: David S. Miller [ upstream commit: 3651751fff44ede58f65cbb1e39242139ead251b ] This causes the lock to be taken twice, thus resulting in a deadlock. Signed-off-by: David S. Miller Signed-off-by: Chris Wright --- drivers/serial/sunhv.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/serial/sunhv.c +++ b/drivers/serial/sunhv.c @@ -499,7 +499,6 @@ static void sunhv_console_write_bychar(s } else spin_lock(&port->lock); - spin_lock_irqsave(&port->lock, flags); for (i = 0; i < n; i++) { if (*s == '\n') sunhv_console_putchar(port, '\r'); -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/