Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754490AbYFNP6S (ORCPT ); Sat, 14 Jun 2008 11:58:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753136AbYFNP6A (ORCPT ); Sat, 14 Jun 2008 11:58:00 -0400 Received: from server.drzeus.cx ([85.8.24.28]:42683 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753122AbYFNP57 (ORCPT ); Sat, 14 Jun 2008 11:57:59 -0400 Date: Sat, 14 Jun 2008 17:57:23 +0200 From: Pierre Ossman To: Anton Vorontsov Cc: David Brownell , Grant Likely , Jochen Friedrich , Segher Boessenkool , Gary Jennejohn , Guennadi Liakhovetski , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver Message-ID: <20080614175723.209e93dc@mjolnir.drzeus.cx> In-Reply-To: <20080605161624.GA517@polina.dev.rtsoft.ru> References: <20080605161624.GA517@polina.dev.rtsoft.ru> X-Mailer: Claws Mail 3.4.0 (GTK+ 2.13.2; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1266 Lines: 39 On Thu, 5 Jun 2008 20:16:24 +0400 Anton Vorontsov wrote: > Here is v3. I'm out of ideas if you won't like it. :-) > > v3: > - Now these bindings are using bus notifiers chain, thus we adhere to the > spi bus. > Now this was nice and clean. I take it Grant doesn't like this version though. What's the downside of it? > > - Plus changed the OF bindings themselves, implemented voltage-range > property. (Pierre, please take a look at vddrange_to_ocrmask(). I > wonder if you would like this in the MMC core instead, with a kernel > doc, of course.) > That might be a good idea in the long run. MMC OCR masks have some gotchas, so it's best if we have as few pieces of code as possible dealing with it. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING: This correspondence is being monitored by the Swedish government. Use end-to-end encryption where possible. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/