Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753515AbYFNQXQ (ORCPT ); Sat, 14 Jun 2008 12:23:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753382AbYFNQXA (ORCPT ); Sat, 14 Jun 2008 12:23:00 -0400 Received: from server.drzeus.cx ([85.8.24.28]:43389 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753307AbYFNQW7 (ORCPT ); Sat, 14 Jun 2008 12:22:59 -0400 Date: Sat, 14 Jun 2008 18:22:20 +0200 From: Pierre Ossman To: Ben Dooks Cc: linux-kernel@vger.kernel.org, Harald Welte , Thomas Kleffel , Roman Moravcik , Ben Dooks Subject: Re: [patch 06/15] MMC: Add platform data for S3C24XX MMC/SD driver Message-ID: <20080614182220.69474ac5@mjolnir.drzeus.cx> In-Reply-To: <20080606155525.687756431@fluff.org.uk> References: <20080606155117.074799346@fluff.org.uk> <20080606155525.687756431@fluff.org.uk> X-Mailer: Claws Mail 3.4.0 (GTK+ 2.13.2; i386-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAMAAABg3Am1AAAAAXNSR0IArs4c6QAAADNQTFRFEgwFRSofeTwxZEI1h1lFl1ZHeGBetHZk24VzuZJ43p2GsbKw/Lmg2MTL/NO3/+/Q//fpWFujUwAAAk5JREFUSMeNlVcWnDAMRd0bLux/tVGxiAEzic7hZ+Zd1IU6NtbYdn8daic/cgj52CPqLQ8hOBdjzsD8G2hHsCiPBS2/nTyABi93zvsYUyql1v6KSz30AeUAJLAK1uuDUI94WA7GDsAePtRDfwFRgP7DA8vvwOgQ1R5oYQUKAwOsfwDHDcAcWH+e5xagiooey1SwSAy0L8C7BaDKdgKWoNQtIjYEfHQGzMcKwNgCpLdgBn14ZzXNSPkJWK201vjiHMkXZg7AuQWCA7G2DPTiMSIsLSZxbgEIwlqEjE+9WBu0yaWOHwDLLQE9WmMieCBgtG1IAFgBzo7tlojGtbI3wFljuU4JdL3ghPeO+tFr2QHG0DOBSuN0kofaU302zmKbcTrgAWDUywG0OvXELi6gZScAdq6WnhYgvYDGu0YQjYSZs3ROID0B4y+jjpWyAhjePWkAjKwD5o09xioNBoro/+YQZjzTg8ce1CJtwFvwAMDFBEjv6cgI0P/u0DqtGJOjNSAm4e0jABxsgDYXSADQw2wwsFyzdePCAviE48QexseKNiGcp4jgKNEVAGC7QEwY5+S6Qpf50NzujHrdYgEKH0o8ZJ/AQR8HAGiaugDjG2i4ddZx4wToPwB0gQsEfjyFRKf1M+kLQC8u5iuoX8BhxYCQJPZXQ7LQdDnQR87/BdCpQQSJpREh7EMSQOvpYwJaqbAHgrUXkWehxhmUUjpsQ+IDSHlzEvidywrtDYSpnHVioNbstBLi9o3Dn/WqZ3Nw1pUQy8bN3/QdiPiVUZfpP4cDVEKd2cXEAAAAAElFTkSuQmCC X-Face: @{|$W51qEixc&6}dq_38NM^&.vv|'{O)ae?DMZ1%VYxuhN2}5VpQ!'gx[{V+8Xw'+cV5*491_)-SU2YT8s@4`H;@:ELS'/P(@.JxxJi/C8mG0H#A^R X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1593 Lines: 49 This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_freyr.drzeus.cx-10614-1213460153-0001-2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 06 Jun 2008 16:51:23 +0100 Ben Dooks wrote: > This patch adds platform data support to the s3mci driver. This allows > flexible board-specific configuration of set_power, card detect and read = only > pins. >=20 > Signed-off-by: Ben Dooks >=20 Please see the changes in my #next branch where you can return -ENOSYS to indicate that you do not know the state of the read only pin. > + > +static struct s3c24xx_mci_pdata s3cmci_def_pdata =3D { > + .gpio_detect =3D 0, > + .set_power =3D NULL, > + .ocr_avail =3D MMC_VDD_32_33, > }; You probably want MMC_VDD_32_32 | MMC_VDD_33_34 here. --=_freyr.drzeus.cx-10614-1213460153-0001-2 Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAkhT8EAACgkQ7b8eESbyJLgTTgCfQbRe5+eI8SWR0YB0eNQTJpCQ /98AoKp6AqJqBreiUX0/zQr1eatQ040B =3sKy -----END PGP SIGNATURE----- --=_freyr.drzeus.cx-10614-1213460153-0001-2-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/