Message-ID: <4855A145.90803@imap.cc>
Date: Mon, 16 Jun 2008 01:09:57 +0200
From: Tilman Schmidt <tilman@imap.cc>
User-Agent: Thunderbird 2.0.0.14 (X11/20080421)
MIME-Version: 1.0
To: Andreas Herrmann <aherrman@arcor.de>
CC: Hansjoerg Lipp <hjlipp@web.de>, gigaset307x-common@lists.sourceforge.net,
       linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
       kkeil@suse.de
Subject: Re: [PATCH] gigaset: fix module reference counting
References: <20080606223918.GA10348@kodscha>
In-Reply-To: <20080606223918.GA10348@kodscha>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig56C37E01A1215C31AC0A9CA5"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1458
Lines: 43

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig56C37E01A1215C31AC0A9CA5
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi Andreas,

On 2008-06-07 00:39, Andreas Herrmann wrote:
> bas_gigaset can't be unloaded due to wrong module reference counting.
> Ensure that module_put is called whenever a channel is freed.

I'm not quite happy with that patch. Specifically, I see a risk of
module_put being called too often.

Could you explain in some more detail what bug you are trying to fix?
Do you have a sequence of events which leads to a situation where the
bas_gigaset module cannot be unloaded but should be?


Thanks,
Tilman


--------------enig56C37E01A1215C31AC0A9CA5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFIVaFQQ3+did9BuFsRAiFFAJ9zpkPsucd5Hwuw22vbAQeiKKDQAwCfUZb7
ZJ4M7sfH1cL1PEpfYYRIjwQ=
=+5NR
-----END PGP SIGNATURE-----

--------------enig56C37E01A1215C31AC0A9CA5--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/