Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755021AbYFPONS (ORCPT ); Mon, 16 Jun 2008 10:13:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753776AbYFPONI (ORCPT ); Mon, 16 Jun 2008 10:13:08 -0400 Received: from an-out-0708.google.com ([209.85.132.251]:63051 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752809AbYFPONH (ORCPT ); Mon, 16 Jun 2008 10:13:07 -0400 Message-ID: Date: Mon, 16 Jun 2008 08:13:06 -0600 From: "Grant Likely" To: "Pierre Ossman" Subject: Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver Cc: "Anton Vorontsov" , "David Brownell" , "Jochen Friedrich" , "Segher Boessenkool" , "Gary Jennejohn" , "Guennadi Liakhovetski" , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org In-Reply-To: <20080614175723.209e93dc@mjolnir.drzeus.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080605161624.GA517@polina.dev.rtsoft.ru> <20080614175723.209e93dc@mjolnir.drzeus.cx> X-Google-Sender-Auth: 3dc830d500fc4389 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1093 Lines: 31 On Sat, Jun 14, 2008 at 9:57 AM, Pierre Ossman wrote: > On Thu, 5 Jun 2008 20:16:24 +0400 > Anton Vorontsov wrote: > >> Here is v3. I'm out of ideas if you won't like it. :-) >> >> v3: >> - Now these bindings are using bus notifiers chain, thus we adhere to the >> spi bus. >> > > Now this was nice and clean. I take it Grant doesn't like this version > though. What's the downside of it? No, I don't. I like the v2 approach better as long as it is been changed to address your comments. This approach I think is needlessly complex and non-obvious (relying on the notification chain instead of being part of the probe call). It will break in non-obvious ways if the notifier module is loaded after the mmc_spi driver. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/