Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752666AbYFPQzK (ORCPT ); Mon, 16 Jun 2008 12:55:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751572AbYFPQy5 (ORCPT ); Mon, 16 Jun 2008 12:54:57 -0400 Received: from mail-out2.uio.no ([129.240.10.58]:46474 "EHLO mail-out2.uio.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbYFPQy5 (ORCPT ); Mon, 16 Jun 2008 12:54:57 -0400 Subject: Re: [PATCH] knfsd: nfsd: Handle ERESTARTSYS from syscalls. From: Trond Myklebust To: Chuck Lever Cc: Peter Staubach , NeilBrown , "J. Bruce Fields" , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <76bd70e30806160809o495dd50fw88a80ec0673c0dc1@mail.gmail.com> References: <20080613213759.26929.patches@notabene> <1080613114215.27095@suse.de> <48565F19.10508@redhat.com> <76bd70e30806160809o495dd50fw88a80ec0673c0dc1@mail.gmail.com> Content-Type: text/plain Date: Mon, 16 Jun 2008 12:54:46 -0400 Message-Id: <1213635286.7238.13.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 Content-Transfer-Encoding: 7bit X-UiO-Resend: resent X-UiO-Spam-info: not spam, SpamAssassin (score=-5.0, required=5.0, autolearn=disabled, UIO_MAIL_IS_INTERNAL=-5, uiobl=NO, uiouri=NO) X-UiO-Scanned: 0034207E4433F11F16146A055334D05350FC21BC X-UiO-SPAM-Test: remote_host: 129.240.10.9 spam_score: -49 maxlevel 200 minaction 2 bait 0 mail/h: 581 total 8956301 max/h 8345 blacklist 0 greylist 0 ratelimit 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 779 Lines: 21 On Mon, 2008-06-16 at 11:09 -0400, Chuck Lever wrote: > I think an error reply is much better than no reply in nearly every > case. NFS3ERR_JUKEBOX/NFS4ERR_DELAY is an interesting idea, but > something else again will probably be required for v4.1 with sessions. NFS3ERR_JUKEBOX/NFS4ERR_DELAY may be inappropriate if the nfs daemon has already started handling the RPC call, since you may be interrupting a non-idempotent operation. The only complete solution to this problem is NFSv4.1 with persistent sessions. Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/