Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754868AbYFQBBe (ORCPT ); Mon, 16 Jun 2008 21:01:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752614AbYFQBBZ (ORCPT ); Mon, 16 Jun 2008 21:01:25 -0400 Received: from smtp-out.google.com ([216.239.33.17]:9749 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbYFQBBZ (ORCPT ); Mon, 16 Jun 2008 21:01:25 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=received:date:from:to:cc:subject:in-reply-to:message-id: references:mime-version:content-type; b=HS06SYvT7bpx6pVf7Bp4JyKf4vpmJ3UqqjpdcrTi5zmbkB5iqgSu1kWIfMYPlEaq6 WR4ZqwKIkqjxf7q0rm1fQ== Date: Mon, 16 Jun 2008 18:01:11 -0700 (PDT) From: Divyesh Shah To: Nick Piggin cc: Divyesh Shah , axboe@kernel.dk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Suleiman Souhlal Subject: Re: [BUGFIX][RESEND] Fix the starving writes bug in the anticipatory IO scheduler In-Reply-To: <200806161318.57435.nickpiggin@yahoo.com.au> Message-ID: References: <935894B7-5FD4-4C3D-9A74-6B18E532462B@google.com> <200806161318.57435.nickpiggin@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 21 On Mon, 16 Jun 2008, Nick Piggin wrote: > Well, thanks for the report and test case. I'm a bit out of the > loop when it comes to IO scheduling these days, however the fix > seems good to me. > > Does google still use AS scheduling? This doesn't introduce any > performance regressions that you can tell? Yes we use AS scheduler. Benchmarking results on workloads have shown that AS does as good a job (and better in some cases) as CFQ. When there is a single thread reading/writing to disk, AS performs as well as CFQ. With multiple threads doing IO such that there are a lot of outstanding requests, CFQ performs worse than AS in terms of throughput. -Divyesh. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/