Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759396AbYFQVfF (ORCPT ); Tue, 17 Jun 2008 17:35:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754555AbYFQVez (ORCPT ); Tue, 17 Jun 2008 17:34:55 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51661 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752803AbYFQVey (ORCPT ); Tue, 17 Jun 2008 17:34:54 -0400 Date: Tue, 17 Jun 2008 14:34:01 -0700 (PDT) From: Linus Torvalds To: Andi Kleen cc: Bron Gondwana , Linux Kernel Mailing List , Nick Piggin , Andrew Morton , Rob Mueller , Ingo Molnar Subject: Re: BUG: mmapfile/writev spurious zero bytes (x86_64/not i386, bisected, reproducable) In-Reply-To: Message-ID: References: <1213682410.13174.1258837181@webmail.messagingengine.com> <1213682570.13708.1258839317@webmail.messagingengine.com> <87od5zwzh2.fsf@basil.nowhere.org> <48582C18.4090900@firstfloor.org> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 602 Lines: 17 On Tue, 17 Jun 2008, Linus Torvalds wrote: > > It is "copy_user". Notice the lack of "from" or "to". That code handles > *both* copy_to_user and copy_from_user. Oh, and yes, I said "copy_to_user_inatomic()" by mistake. The fact is that "write()" obviously does copy_from_user, but more importantly that on x86 it's THE EXACT SAME ROUTINE. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/