Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759635AbYFQVf2 (ORCPT ); Tue, 17 Jun 2008 17:35:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758867AbYFQVfD (ORCPT ); Tue, 17 Jun 2008 17:35:03 -0400 Received: from one.firstfloor.org ([213.235.205.2]:52238 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758632AbYFQVfC (ORCPT ); Tue, 17 Jun 2008 17:35:02 -0400 Message-ID: <48582E03.1040404@firstfloor.org> Date: Tue, 17 Jun 2008 23:34:59 +0200 From: Andi Kleen User-Agent: Thunderbird 1.5.0.12 (X11/20060911) MIME-Version: 1.0 To: Linus Torvalds CC: Bron Gondwana , Linux Kernel Mailing List , Nick Piggin , Andrew Morton , Rob Mueller , Ingo Molnar Subject: Re: BUG: mmapfile/writev spurious zero bytes (x86_64/not i386, bisected, reproducable) References: <1213682410.13174.1258837181@webmail.messagingengine.com> <1213682570.13708.1258839317@webmail.messagingengine.com> <87od5zwzh2.fsf@basil.nowhere.org> <48582C18.4090900@firstfloor.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 34 Linus Torvalds wrote: > > On Tue, 17 Jun 2008, Andi Kleen wrote: >> Loads are not supposed to fault in copy_to_user(). Only stores are. > > Andi, just shut up already. > > It is "copy_user". Notice the lack of "from" or "to". That code handles > *both* copy_to_user and copy_from_user. Yes, but it assumes only one can fault at a time. > >> If your patch fixes something then the main wrong thing is the caller >> who passes a faulting source address. > > Andi, SHUT THE F*CK UP. Read the code. Read the patch. I did exactly the same patch first on your first email and then I realized it was wrong before posting ;-) > Sorry for ever > involving you. I don't want to hear your idiotic whining. The patch is wrong because it'll break the other case (in this case copy_from_user) -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/