Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759910AbYFQVu5 (ORCPT ); Tue, 17 Jun 2008 17:50:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753391AbYFQVur (ORCPT ); Tue, 17 Jun 2008 17:50:47 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:55885 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756809AbYFQVuq (ORCPT ); Tue, 17 Jun 2008 17:50:46 -0400 Date: Tue, 17 Jun 2008 14:49:52 -0700 (PDT) From: Linus Torvalds To: Andi Kleen cc: Al Viro , Bron Gondwana , Linux Kernel Mailing List , Nick Piggin , Andrew Morton , Rob Mueller , Ingo Molnar Subject: Re: BUG: mmapfile/writev spurious zero bytes (x86_64/not i386, bisected, reproducable) In-Reply-To: <48582FAB.1020402@firstfloor.org> Message-ID: References: <1213682410.13174.1258837181@webmail.messagingengine.com> <1213682570.13708.1258839317@webmail.messagingengine.com> <485829A1.4020705@firstfloor.org> <20080617213618.GL28946@ZenIV.linux.org.uk> <48582FAB.1020402@firstfloor.org> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 960 Lines: 32 On Tue, 17 Jun 2008, Andi Kleen wrote: > > Linus seems to think that copy_to_user() should have > copy_in_user semantics(). No. I *know* that copy_to/from_user() is supposed to return the number of bytes not copied. And if you loaded a value but didn't store it to the destination, then BY DEFINITION you didn't copy it. Comprende? Obviously you don't. Gaah. Why do I keep bothering to even _try_ to educate you? Can't you accept that I just fixed a bug, which had a test-case an everything? Andi, really. Take it from me. If I tell you something, I'm usually right. Think about that for a moment, instead of living in your own little dream-world where you think you understand everything. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/