Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760148AbYFRF1o (ORCPT ); Wed, 18 Jun 2008 01:27:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753769AbYFRF1f (ORCPT ); Wed, 18 Jun 2008 01:27:35 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:50810 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753593AbYFRF1e (ORCPT ); Wed, 18 Jun 2008 01:27:34 -0400 Date: Wed, 18 Jun 2008 14:26:14 +0900 From: KOSAKI Motohiro To: KAMEZAWA Hiroyuki Subject: Re: [PATCH] migration_entry_wait fix. Cc: kosaki.motohiro@jp.fujitsu.com, Daisuke Nishimura , Andrew Morton , Rik van Riel , Lee Schermerhorn , Nick Piggin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, "hugh@veritas.com" In-Reply-To: <20080618105435.de10d6bc.kamezawa.hiroyu@jp.fujitsu.com> References: <20080618101349.db4d5205.kamezawa.hiroyu@jp.fujitsu.com> <20080618105435.de10d6bc.kamezawa.hiroyu@jp.fujitsu.com> Message-Id: <20080618142517.37A6.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1080 Lines: 33 > From: Daisuke Nishimura > Signed-off-by: Daisuke Nishimura > Signed-off-by: KAMEZAWA Hiroyuki > --- > mm/migrate.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: test-2.6.26-rc5-mm3/mm/migrate.c > =================================================================== > --- test-2.6.26-rc5-mm3.orig/mm/migrate.c > +++ test-2.6.26-rc5-mm3/mm/migrate.c > @@ -243,7 +243,8 @@ void migration_entry_wait(struct mm_stru > > page = migration_entry_to_page(entry); > > - get_page(page); > + if (!page_cache_get_speculative(page)) > + goto out; > pte_unmap_unlock(ptep, ptl); > wait_on_page_locked(page); > put_page(page); sorry, so late responce. Acked-by: KOSAKI Motohiro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/