Date: Wed, 18 Jun 2008 09:51:37 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Robert Richter <robert.richter@amd.com>
Cc: Glauber Costa <glommer@gmail.com>, Arjan van de Ven <arjan@infradead.org>,
       Yinghai Lu <yhlu.kernel@gmail.com>,
       Thomas Gleixner <tglx@linutronix.de>,
       LKML <linux-kernel@vger.kernel.org>, Andi Kleen <andi@firstfloor.org>,
       the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH 2/2] x86: Move PCI IO ECS code to x86/pci
Message-ID: <20080618075137.GC4135@elte.hu>
References: <20080603072550.GR23679@erda.amd.com> <1213294763-19566-2-git-send-email-robert.richter@amd.com> <5d6222a80806131002t4f5c6e54tee63d4ed0fc222a6@mail.gmail.com> <20080613181627.GH10019@erda.amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080613181627.GH10019@erda.amd.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1151
Lines: 28


* Robert Richter <robert.richter@amd.com> wrote:

> Ok, so what about shared code? Keep all this in separate files: 
> amd_bus.c, (amd_bus_32.c), amd_bus_64.c, (amd_bus.h)?
> 
> Is the strategy to avoid #ifdefs and instead use the flags in 
> Makefiles? My intention was to coalesce the files. Maybe I was wrong 
> here.

What you did is fine - first step is to move the variants as close to 
each other as possible, in an as obvious and mechanic step as possible.

If anything breaks due to your patches then they were probably too 
large, but lets be optimistic and try your current splitup first :)

Then we can start eliminating any leftover #ifdefs, step by step. Please 
send very, very small patches for that (put them into a git tree on 
kernel.org if there's more than say a dozen of them), we'll test them, 
and if the changes break anything it's all bisectable to an individual 
change.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/