Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753951AbYFRKTZ (ORCPT ); Wed, 18 Jun 2008 06:19:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752514AbYFRKTQ (ORCPT ); Wed, 18 Jun 2008 06:19:16 -0400 Received: from jenny.ondioline.org ([66.220.1.122]:46356 "EHLO jenny.ondioline.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506AbYFRKTP (ORCPT ); Wed, 18 Jun 2008 06:19:15 -0400 From: Paul Collins To: "Phil Endecott" Cc: , , , , "Marcel Holtmann" Subject: Re: [PATCH] [RESEND] fix HID quirks for aluminium apple wireless keyboards References: <87tzfwiguc.fsf@burly.wgtn.ondioline.org> <1213447893811@dmwebmail.dmwebmail.chezphil.org> Mail-Followup-To: "Phil Endecott" , , , , , "Marcel Holtmann" Date: Wed, 18 Jun 2008 22:19:13 +1200 In-Reply-To: <1213447893811@dmwebmail.dmwebmail.chezphil.org> (Phil Endecott's message of "Sat, 14 Jun 2008 13:51:33 +0100") Message-ID: <87mylj2ggu.fsf@burly.wgtn.ondioline.org> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 22 "Phil Endecott" writes: > Why do you set HID_QUIRK_APPLE_NUMLOCK_EMULATION ? I don't know what > that quirk really does, but since these keyboards have neither a > numeric keypad nor a numlock key I can't see any benefit. >From a quick skim of the code (drivers/hid/hid-input.c) it looks like it's supposed to allow a laptop-style numeric keymap mapping to be enabled with F6, but I can't make it do anything here. Perhaps it is best removed after the hid-bus merge, otherwise there'll be different quirks in different places for the same devices. -- Paul Collins Wellington, New Zealand Dag vijandelijk luchtschip de huismeester is dood -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/