Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755131AbYFRSWp (ORCPT ); Wed, 18 Jun 2008 14:22:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753161AbYFRSWh (ORCPT ); Wed, 18 Jun 2008 14:22:37 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:57760 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753076AbYFRSWh (ORCPT ); Wed, 18 Jun 2008 14:22:37 -0400 Date: Wed, 18 Jun 2008 14:22:23 -0400 From: Christoph Hellwig To: Jeff Moyer Cc: akpm@linux-foundation.org, zach.brown@oracle.com, linux-aio@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch] aio: invalidate async directio writes Message-ID: <20080618182223.GA14851@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1093 Lines: 26 On Wed, Jun 18, 2008 at 02:09:51PM -0400, Jeff Moyer wrote: > + /* For async O_DIRECT writes, we need to invalidate the > + * page cache after the write completes. Kick off a > + * workqueue to do this and issue the completion in process > + * context. > + */ > + if (dio->rw == READ) { > + int ret = dio_complete(dio, dio->iocb->ki_pos, 0); > + aio_complete(dio->iocb, ret, 0); > + kfree(dio); > + } else { > + unsigned long flags; > + spin_lock_irqsave(&iocb_completion_list_lock, flags); > + list_add(&dio->done_list, &iocb_completion_list); > + spin_unlock_irqrestore(&iocb_completion_list_lock, flags); > + schedule_work(&aio_complete_work); > + } Can we please move all these aio_complete calls to user context? Having AIO contexts completing from irq context is a major pain for complex filesystems like XFS. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/