Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755197AbYFRTsq (ORCPT ); Wed, 18 Jun 2008 15:48:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752470AbYFRTsi (ORCPT ); Wed, 18 Jun 2008 15:48:38 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:58877 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbYFRTsh (ORCPT ); Wed, 18 Jun 2008 15:48:37 -0400 Date: Wed, 18 Jun 2008 15:48:23 -0400 From: Christoph Hellwig To: Jeff Moyer Cc: Christoph Hellwig , akpm@linux-foundation.org, zach.brown@oracle.com, linux-aio@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch] aio: invalidate async directio writes Message-ID: <20080618194823.GA7237@infradead.org> References: <20080618182223.GA14851@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 977 Lines: 20 On Wed, Jun 18, 2008 at 03:45:28PM -0400, Jeff Moyer wrote: > > Can we please move all these aio_complete calls to user context? Having > > AIO contexts completing from irq context is a major pain for complex > > filesystems like XFS. > > Can you help me understand why this is a pain? I'm having trouble > making the connection. With your patch we complete aio dio write request in user context, which is great for filesystems that need to do more complex activity in the completion handler, e.g. XFS for the unwritten extent conversion. But only doing this for the write case is only very partially useful, we should be doing this for the read case, too. See fs/xfs/linux-2.6/xfs_aops.c:xfs_end_io_direct() for what I mean. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/