Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755057AbYFRWJ1 (ORCPT ); Wed, 18 Jun 2008 18:09:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754259AbYFRWJR (ORCPT ); Wed, 18 Jun 2008 18:09:17 -0400 Received: from webmail.e-teleport.net ([213.190.83.68]:57163 "EHLO mail.imsnet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754145AbYFRWJQ (ORCPT ); Wed, 18 Jun 2008 18:09:16 -0400 Message-ID: <48598784.40306@e-teleport.net> Date: Thu, 19 Jun 2008 00:09:08 +0200 From: =?ISO-8859-1?Q?S=E9guier_R=E9gis?= User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: Francois Romieu Cc: Andrew Morton , Arjan van de Ven , alan@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bug during MTU change References: <20080531184615.350bac00@infradead.org> <20080603134019.df2f51d4.akpm@linux-foundation.org> <20080603215155.GA9712@electric-eye.fr.zoreil.com> <20080604215909.GA17446@electric-eye.fr.zoreil.com> <20080614212341.GA12976@electric-eye.fr.zoreil.com> <4856DA62.7080803@e-teleport.net> <20080617214538.GA6388@electric-eye.fr.zoreil.com> <48584AA4.8040801@e-teleport.net> <48593E35.1010409@e-teleport.net> <20080618201012.GA4019@electric-eye.fr.zoreil.com> In-Reply-To: <20080618201012.GA4019@electric-eye.fr.zoreil.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1014 Lines: 34 Francois Romieu a ?crit : > S?guier R?gis : > [...] > >> This correction seems to work. >> >> I read somewhere pci_free_consistent (in velocity_free_dma_rings) couldn't >> be use in a spin_lock. >> > > Yup. > > >> When I move velocity_free_rings outside the spin_lock, error desappeare but >> data transfert doesn't work after the mtu change. >> When I add velocity_give_many_rx_descs all work. >> > > I have updated http://userweb.kernel.org/~romieu/via-velocity/2.6.26-rc6/ > accordingly. Can you check whether it is fine or not ? > > Patch 0001 doesn't work, if I don't make a mistake skb->len is not modified in skb_pad{,to}when the padding is applied. In this case, we need to attribute ETH_ZLEN to len. -- R?gis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/