Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757489AbYFSAo6 (ORCPT ); Wed, 18 Jun 2008 20:44:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755803AbYFSAov (ORCPT ); Wed, 18 Jun 2008 20:44:51 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:52835 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754744AbYFSAou (ORCPT ); Wed, 18 Jun 2008 20:44:50 -0400 Message-ID: <4859ABA6.4000904@cn.fujitsu.com> Date: Thu, 19 Jun 2008 08:43:18 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Paul Menage CC: Andrew Morton , LKML , "containers@lists.osdl.org" , Balbir Singh , KAMEZAWA Hiroyuki , Paul Jackson Subject: Re: [PATCH] cgroup: support checking of subsystem dependencies References: <4858C0ED.2080905@cn.fujitsu.com> <6599ad830806181413y5d0ef1bfyfc54c17ee904d744@mail.gmail.com> In-Reply-To: <6599ad830806181413y5d0ef1bfyfc54c17ee904d744@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 742 Lines: 22 >> static int cgroup_remount(struct super_block *sb, int *flags, char *data) >> { >> int ret = 0; >> @@ -852,6 +871,10 @@ static int cgroup_remount(struct super_block *sb, int *flags, char *data) >> if (ret) >> goto out_unlock; >> >> + ret = check_subsys_dependency(opts.subsys_bits); >> + if (ret) >> + goto out_unlock; >> + > > Can we just call this from one place, in parse_cgroupfs_options() ? > I think yes we can. I'll revise it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/