Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757444AbYFSJSX (ORCPT ); Thu, 19 Jun 2008 05:18:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754304AbYFSJSQ (ORCPT ); Thu, 19 Jun 2008 05:18:16 -0400 Received: from smtp.movial.fi ([62.236.91.34]:53713 "EHLO smtp.movial.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753615AbYFSJSP (ORCPT ); Thu, 19 Jun 2008 05:18:15 -0400 Message-ID: <485A249F.9070506@movial.fi> Date: Thu, 19 Jun 2008 12:19:27 +0300 From: Dmitri Vorobiev Organization: Movial Creative Technologies User-Agent: Icedove 1.5.0.14eol (X11/20080509) MIME-Version: 1.0 To: Paolo Ciarrocchi , Ingo Molnar CC: Andy Whitcroft , tglx , hpa , Linux Kernel Subject: Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg_constant References: <20080614204452.25378bd0@paolo-desktop> <48590926.5060009@movial.fi> <4d8e3fd30806180719j718a3b1ds461495c4d3de8236@mail.gmail.com> <20080619090715.GK30959@shadowen.org> In-Reply-To: <20080619090715.GK30959@shadowen.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1302 Lines: 31 Andy Whitcroft wrote: > On Wed, Jun 18, 2008 at 04:19:38PM +0200, Paolo Ciarrocchi wrote: >> On Wed, Jun 18, 2008 at 3:09 PM, Dmitri Vorobiev >> wrote: >>> Paolo Ciarrocchi wrote: >>>> -static void fld_const(FPU_REG const *c, int adj, u_char tag) >>>> +static void fld_const(FPU_REG const * c, int adj, u_char tag) >>> ________________________________________^ >>> >>> The above does not seem to me like a big improvement in code quality. A >>> false positive from checkpatch.pl? >> Yes, I think you are right. >> Andy CC'ed so that he can have a look at that. > > That would be a false positive if we are recommending that. I have > pushed this fragment in isolation through all versions back to 0.15 and > none of them recommend it. > > Ahh, but if I push the whole patch through 0.19 spits it out. Ok this > is a subtle bug in modifier procesing and is fixed in the head of my > tree. Will be fixed in the next batch which goes up to -mm. Maybe it makes sense for Ingo to revert the original Paolo's patch now? Dmitri -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/