Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757122AbYFSKFx (ORCPT ); Thu, 19 Jun 2008 06:05:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754972AbYFSKFp (ORCPT ); Thu, 19 Jun 2008 06:05:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48944 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754909AbYFSKFo (ORCPT ); Thu, 19 Jun 2008 06:05:44 -0400 Date: Thu, 19 Jun 2008 12:05:42 +0200 Message-ID: From: Takashi Iwai To: Rene Herman Cc: Pierre Ossman , ALSA devel , linux-kernel@vger.kernel.org, mulix@mulix.org Subject: Re: [alsa-devel] looping S/PDIF data In-Reply-To: <4858B84B.4030800@keyaccess.nl> References: <20080531112606.5884a1c9@mjolnir.drzeus.cx> <20080617215504.3203a5ed@mjolnir.drzeus.cx> <4858B84B.4030800@keyaccess.nl> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (x86_64-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1558 Lines: 47 At Wed, 18 Jun 2008 09:24:59 +0200, Rene Herman wrote: > > On 17-06-08 21:55, Pierre Ossman wrote: > > > Ping > > > > On Sat, 31 May 2008 11:26:06 +0200 > > Pierre Ossman wrote: > > > >> I have a minor annoyance with the snd_trident driver that I was hoping > >> you might have a fix for: > >> > >> Pausing the output does not seem to take on the S/PDIF output. Analog > >> outputs properly stop in their tracks, but the S/PDIF port keeps > >> looping the current data buffer, which gives a rather unpleasant end > >> result. :) > > Try the alsa-devel list... Does the patch below help? Takashi diff --git a/sound/pci/trident/trident_main.c b/sound/pci/trident/trident_main.c index bbcee2c..916d4b8 100644 --- a/sound/pci/trident/trident_main.c +++ b/sound/pci/trident/trident_main.c @@ -1593,7 +1593,11 @@ static int snd_trident_trigger(struct snd_pcm_substream *substream, outb(trident->spdif_pcm_ctrl, TRID_REG(trident, NX_SPCTRL_SPCSO + 3)); } else { outl(trident->spdif_pcm_bits, TRID_REG(trident, SI_SPDIF_CS)); - val = inl(TRID_REG(trident, SI_SERIAL_INTF_CTRL)) | SPDIF_EN; + val = inl(TRID_REG(trident, SI_SERIAL_INTF_CTRL)); + if (go) + val |= SPDIF_EN; + else + val &= ~SPDIF_EN; outl(val, TRID_REG(trident, SI_SERIAL_INTF_CTRL)); } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/