Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759539AbYFSMjY (ORCPT ); Thu, 19 Jun 2008 08:39:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757416AbYFSMjM (ORCPT ); Thu, 19 Jun 2008 08:39:12 -0400 Received: from mail1.perex.cz ([212.20.107.53]:6637 "EHLO mail1.perex.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756594AbYFSMjK (ORCPT ); Thu, 19 Jun 2008 08:39:10 -0400 Date: Thu, 19 Jun 2008 14:39:05 +0200 (CEST) From: Jaroslav Kysela X-X-Sender: perex@tm8103-a.perex-int.cz To: Takashi Iwai cc: Rene Herman , ALSA devel , mulix@mulix.org, Pierre Ossman , LKML Subject: Re: [alsa-devel] looping S/PDIF data In-Reply-To: Message-ID: References: <20080531112606.5884a1c9@mjolnir.drzeus.cx> <20080617215504.3203a5ed@mjolnir.drzeus.cx> <4858B84B.4030800@keyaccess.nl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2044 Lines: 65 On Thu, 19 Jun 2008, Takashi Iwai wrote: > At Wed, 18 Jun 2008 09:24:59 +0200, > Rene Herman wrote: > > > > On 17-06-08 21:55, Pierre Ossman wrote: > > > > > Ping > > > > > > On Sat, 31 May 2008 11:26:06 +0200 > > > Pierre Ossman wrote: > > > > > >> I have a minor annoyance with the snd_trident driver that I was hoping > > >> you might have a fix for: > > >> > > >> Pausing the output does not seem to take on the S/PDIF output. Analog > > >> outputs properly stop in their tracks, but the S/PDIF port keeps > > >> looping the current data buffer, which gives a rather unpleasant end > > >> result. :) > > > > Try the alsa-devel list... > > Does the patch below help? > > > Takashi > > diff --git a/sound/pci/trident/trident_main.c b/sound/pci/trident/trident_main.c > index bbcee2c..916d4b8 100644 > --- a/sound/pci/trident/trident_main.c > +++ b/sound/pci/trident/trident_main.c > @@ -1593,7 +1593,11 @@ static int snd_trident_trigger(struct snd_pcm_substream *substream, > outb(trident->spdif_pcm_ctrl, TRID_REG(trident, NX_SPCTRL_SPCSO + 3)); > } else { > outl(trident->spdif_pcm_bits, TRID_REG(trident, SI_SPDIF_CS)); > - val = inl(TRID_REG(trident, SI_SERIAL_INTF_CTRL)) | SPDIF_EN; > + val = inl(TRID_REG(trident, SI_SERIAL_INTF_CTRL)); > + if (go) > + val |= SPDIF_EN; > + else > + val &= ~SPDIF_EN; > outl(val, TRID_REG(trident, SI_SERIAL_INTF_CTRL)); > } > } I don't think that this patch is correct. DMA transfers should be disabled by: outl(what, TRID_REG(trident, T4D_STOP_B)); outl(val, TRID_REG(trident, T4D_AINTEN_B)); lines. Adding &= ~SPDIF_EN can disable output from AC97 to S/PDIF as well. Jaroslav ----- Jaroslav Kysela Linux Kernel Sound Maintainer ALSA Project, Red Hat, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/