Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756295AbYFSOjm (ORCPT ); Thu, 19 Jun 2008 10:39:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752052AbYFSOjf (ORCPT ); Thu, 19 Jun 2008 10:39:35 -0400 Received: from gateway-1237.mvista.com ([63.81.120.158]:24877 "EHLO gateway-1237.mvista.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbYFSOje (ORCPT ); Thu, 19 Jun 2008 10:39:34 -0400 Subject: Re: 2.6.26-rc5-mm3 From: Daniel Walker To: Ingo Molnar Cc: Byron Bradley , Andrew Morton , linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, linux-mm@kvack.org, Hua Zhong In-Reply-To: <20080619091337.GA15228@elte.hu> References: <20080611225945.4da7bb7f.akpm@linux-foundation.org> <1213811751.11203.73.camel@localhost.localdomain> <20080619091337.GA15228@elte.hu> Content-Type: text/plain Date: Thu, 19 Jun 2008 07:39:30 -0700 Message-Id: <1213886370.11203.80.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-5.fc8) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1491 Lines: 52 On Thu, 2008-06-19 at 11:13 +0200, Ingo Molnar wrote: > the better fix would be to add likely_prof.o to this list of exceptions > in lib/Makefile: > > ifdef CONFIG_FTRACE > # Do not profile string.o, since it may be used in early boot or vdso > CFLAGS_REMOVE_string.o = -pg > # Also do not profile any debug utilities > CFLAGS_REMOVE_spinlock_debug.o = -pg > CFLAGS_REMOVE_list_debug.o = -pg > CFLAGS_REMOVE_debugobjects.o = -pg > endif > > instead of adding notrace to the source. > > Ingo Here's the fix mentioned above. -- Remove tracing from likely profiling since it could cause recursion if ftrace uses likely/unlikely macro's internally. Signed-off-by: Daniel Walker --- lib/Makefile | 2 ++ 1 file changed, 2 insertions(+) Index: linux-2.6.25/lib/Makefile =================================================================== --- linux-2.6.25.orig/lib/Makefile +++ linux-2.6.25/lib/Makefile @@ -15,6 +15,8 @@ CFLAGS_REMOVE_string.o = -pg CFLAGS_REMOVE_spinlock_debug.o = -pg CFLAGS_REMOVE_list_debug.o = -pg CFLAGS_REMOVE_debugobjects.o = -pg +# likely profiling can cause recursion in ftrace, so don't trace it. +CFLAGS_REMOVE_likely_prof.o = -pg endif lib-$(CONFIG_MMU) += ioremap.o -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/