Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751628AbYFTEKZ (ORCPT ); Fri, 20 Jun 2008 00:10:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750748AbYFTEKN (ORCPT ); Fri, 20 Jun 2008 00:10:13 -0400 Received: from mga09.intel.com ([134.134.136.24]:43452 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbYFTEKM (ORCPT ); Fri, 20 Jun 2008 00:10:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.27,674,1204531200"; d="scan'208";a="399836398" Date: Fri, 20 Jun 2008 12:09:52 +0800 From: Kent Liu To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com Subject: [PATCH]Don't calculate vm_total_pages twice when rebuild zonelists in online_pages() Message-ID: <20080620040952.GA18061@wliu-linux.bj.intel.com> References: <20080619003844.GA14121@wliu-linux.bj.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080619003844.GA14121@wliu-linux.bj.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 35 Resend the patch with more appropriate subject -- adding [PATCH] prefix. Please consider it. ----- If zonelist is required to be rebuilt in online_pages(), there is no need to recalculate vm_total_pages in that function, as it has been updated in the call build_all_zonelists(). Signed-off-by: Kent Liu Acked-by: KAMEZAWA Hiroyuki --- mm/memory_hotplug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 833f854..896ddaf 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -429,7 +429,9 @@ int online_pages(unsigned long pfn, unsigned long nr_pages) if (need_zonelists_rebuild) build_all_zonelists(); - vm_total_pages = nr_free_pagecache_pages(); + else + vm_total_pages = nr_free_pagecache_pages(); + writeback_set_ratelimit(); if (onlined_pages) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/