Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758723AbYFTOiY (ORCPT ); Fri, 20 Jun 2008 10:38:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755869AbYFTOiQ (ORCPT ); Fri, 20 Jun 2008 10:38:16 -0400 Received: from sj-iport-1.cisco.com ([171.71.176.70]:40797 "EHLO sj-iport-1.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755834AbYFTOiP (ORCPT ); Fri, 20 Jun 2008 10:38:15 -0400 X-IronPort-AV: E=Sophos;i="4.27,679,1204531200"; d="scan'208";a="42893125" From: Roland Dreier To: Ingo Molnar Cc: Jiri Slaby , linux-kernel@vger.kernel.org, Eli Cohen , general@lists.openfabrics.org, Oleg Nesterov , Peter Zijlstra Subject: Re: wait_for_completion_timeout() spurious failure under heavy load? References: <485B50F1.2020802@gmail.com> <20080620112042.GE7439@elte.hu> X-Message-Flag: Warning: May contain useful information Date: Fri, 20 Jun 2008 07:33:02 -0700 In-Reply-To: <20080620112042.GE7439@elte.hu> (Ingo Molnar's message of "Fri, 20 Jun 2008 13:20:42 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 20 Jun 2008 14:33:02.0844 (UTC) FILETIME=[8BB5ABC0:01C8D2E2] Authentication-Results: sj-dkim-3; header.From=rdreier@cisco.com; dkim=pass ( sig from cisco.com/sjdkim3002 verified; ); Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 525 Lines: 21 > but like in the commit below. Agreed? > + > + /* > + * If the completion has arrived meanwhile > + * then return 1 jiffy time left: > + */ > + if (x->done && !timeout) { > + timeout = 1; > + break; > + } > + Sure, that looks nice to me. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/