Date: Fri, 20 Jun 2008 17:43:54 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Cliff Wickman <cpw@sgi.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>, andi@firstfloor.org,
       tglx@linutronix.de, linux-kernel@vger.kernel.org,
       the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH] X86: reboot-notify additions
Message-ID: <20080620154354.GA6656@elte.hu>
References: <E1K95kd-00081i-B6@eag09.americas.sgi.com> <20080619110214.GJ15228@elte.hu> <20080619145453.GA11929@sgi.com> <m1d4mdksau.fsf@frodo.ebiederm.org> <20080620151650.GA5606@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080620151650.GA5606@sgi.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1115
Lines: 32


* Cliff Wickman <cpw@sgi.com> wrote:

> --- linux.orig/kernel/sys.c
> +++ linux/kernel/sys.c
> @@ -267,9 +267,16 @@ out_unlock:
>   *	reboot the system.  This is called when we know we are in
>   *	trouble so this is our best effort to reboot.  This is
>   *	safe to call in interrupt context.
> + *
> + *	The reboot_notifier_list uses a header for a blocking-form scan.
> + *	Use a local header suitable for a non-blocking scan.
>   */
>  void emergency_restart(void)
>  {
> +	struct raw_notifier_head rh;
> +
> +	rh.head = reboot_notifier_list.head;
> +	raw_notifier_call_chain(&rh, SYS_EMERGENCY, NULL);
>  	machine_emergency_restart();
>  }

that's still not a good idea - a blocking notifier list is that: a list 
that has stuff which might block. emergency_restart() might get called 
by non-blocking codepaths as well and it expects the restart to occur.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/