Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933807AbYFTUtT (ORCPT ); Fri, 20 Jun 2008 16:49:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754173AbYFTUlh (ORCPT ); Fri, 20 Jun 2008 16:41:37 -0400 Received: from g1t0027.austin.hp.com ([15.216.28.34]:16653 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932494AbYFTUle (ORCPT ); Fri, 20 Jun 2008 16:41:34 -0400 Subject: Re: [Experimental][PATCH] putback_lru_page rework From: Lee Schermerhorn To: KAMEZAWA Hiroyuki Cc: Daisuke Nishimura , Andrew Morton , Rik van Riel , Kosaki Motohiro , Nick Piggin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org In-Reply-To: <1213981843.6474.68.camel@lts-notebook> References: <20080611225945.4da7bb7f.akpm@linux-foundation.org> <20080617163501.7cf411ee.nishimura@mxp.nes.nec.co.jp> <20080617164709.de4db070.nishimura@mxp.nes.nec.co.jp> <20080618184000.a855dfe0.kamezawa.hiroyu@jp.fujitsu.com> <1213813266.6497.14.camel@lts-notebook> <20080619092242.79648592.kamezawa.hiroyu@jp.fujitsu.com> <1213886722.6398.29.camel@lts-notebook> <20080620101352.e1200b8e.kamezawa.hiroyu@jp.fujitsu.com> <1213981843.6474.68.camel@lts-notebook> Content-Type: text/plain Organization: HP/OSLO Date: Fri, 20 Jun 2008 16:41:29 -0400 Message-Id: <1213994489.6474.127.camel@lts-notebook> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 28 On Fri, 2008-06-20 at 13:10 -0400, Lee Schermerhorn wrote: > On Fri, 2008-06-20 at 10:13 +0900, KAMEZAWA Hiroyuki wrote: > > Lee-san, this is an additonal one.. > > Not-tested-yet, just by review. > > OK, I'll test this on my x86_64 platform, which doesn't seem to hit the > soft lockups. > Quick update: With this patch applied, at ~ 1.5 hours into the test, my system panic'd [panic_on_oops set] with a BUG in __find_get_block() -- looks like the BUG_ON() in check_irqs_on() called from bh_lru_install() inlined by __find_get_block(). Before the panic occurred, I saw warnings from native_smp_call_function_mask() [arch/x86/kernel/smp.c]--also because irqs_disabled(). I'll back out the changes [spin_[un]lock() => spin_[un]lock_irq()] to shrink_inactive_list() and try again. Just a hunch. Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/