Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753557AbYFVATB (ORCPT ); Sat, 21 Jun 2008 20:19:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751662AbYFVASv (ORCPT ); Sat, 21 Jun 2008 20:18:51 -0400 Received: from relay1.sgi.com ([192.48.171.29]:39878 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751374AbYFVASu (ORCPT ); Sat, 21 Jun 2008 20:18:50 -0400 Date: Sat, 21 Jun 2008 17:18:48 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Mel Gorman cc: Alexander Beregalov , kernel-testers@vger.kernel.org, kernel list , linux-mm@kvack.org, Lee Schermerhorn , KAMEZAWA Hiroyuki , Hugh Dickins , Nick Piggin , Andrew Morton , Linus Torvalds , bfields@fieldses.org, neilb@suse.de, linux-nfs@vger.kernel.org Subject: Re: 2.6.26-rc: nfsd hangs for a few sec In-Reply-To: <20080621224135.GD4692@csn.ul.ie> Message-ID: References: <20080621224135.GD4692@csn.ul.ie> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2211 Lines: 65 On Sat, 21 Jun 2008, Mel Gorman wrote: > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1249,15 +1249,13 @@ static unsigned long shrink_zone(int priority, struct zone *zone, > static unsigned long shrink_zones(int priority, struct zonelist *zonelist, > struct scan_control *sc) > { > + enum zone_type high_zoneidx = gfp_zone(sc->gfp_mask); > unsigned long nr_reclaimed = 0; > - struct zone **zones = zonelist->zones; > - int i; > - > + struct zone **z; > + struct zone *zone; > > sc->all_unreclaimable = 1; > - for (i = 0; zones[i] != NULL; i++) { > - struct zone *zone = zones[i]; > - > + for_each_zone_zonelist(zone, z, zonelist, high_zoneidx) { > if (!populated_zone(zone)) > continue; > /* > > Code before - Walk the zonelist for GFP_KERNEL Before the change we walk all zones of the zonelist. > Code after - Filter zonelist based on what is allowed for GFP_KERNEL After the change we walk only zones for GFP_KERNEL. Meaning no HIGHMEM and MOVABLE zones. Doesnt that mean that reclaim is limited to ZONE_DMA and ZONE_NORMAL? Is that really intended? If not then the following patch should return us to old behavior: --- mm/vmscan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6/mm/vmscan.c =================================================================== --- linux-2.6.orig/mm/vmscan.c 2008-06-21 17:15:45.597627317 -0700 +++ linux-2.6/mm/vmscan.c 2008-06-21 17:17:16.273293260 -0700 @@ -1249,13 +1249,12 @@ static unsigned long shrink_zone(int pri static unsigned long shrink_zones(int priority, struct zonelist *zonelist, struct scan_control *sc) { - enum zone_type high_zoneidx = gfp_zone(sc->gfp_mask); unsigned long nr_reclaimed = 0; struct zoneref *z; struct zone *zone; sc->all_unreclaimable = 1; - for_each_zone_zonelist(zone, z, zonelist, high_zoneidx) { + for_each_zone_zonelist(zone, z, zonelist, MAX_NR_ZONES - 1) { if (!populated_zone(zone)) continue; /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/