Date: Sun, 22 Jun 2008 13:17:52 +0300
From: Adrian Bunk <bunk@kernel.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
       rmk@arm.linux.org.uk, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [2.6 patch] fix BLK_DEV_HD_ONLY on ARM dependencies
Message-ID: <20080622101752.GG27069@cs181133002.pp.htv.fi>
References: <20080609222155.GA1987@cs181133002.pp.htv.fi> <200806101956.15711.bzolnier@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <200806101956.15711.bzolnier@gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2406
Lines: 54

On Tue, Jun 10, 2008 at 07:56:15PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Tuesday 10 June 2008, Adrian Bunk wrote:
> > This patch limits BLK_DEV_HD_ONLY to the ARM platforms offering 
> > IRQ_HARDDISK, fixing the following compile error on others:
> > 
> > <--  snip  -->
> > 
> > ...
> >   CC      drivers/ide/legacy/hd.o
> > ...
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c: In function 'hd_times_out':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:542: error: 'IRQ_HARDDISK' undeclared (first use in this function)
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:542: error: (Each undeclared identifier is reported only once
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:542: error: for each function it appears in.)
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c: In function 'do_hd_request':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:661: error: 'IRQ_HARDDISK' undeclared (first use in this function)
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c: In function 'hd_init':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:765: error: 'IRQ_HARDDISK' undeclared (first use in this function)
> > make[3]: *** [drivers/ide/legacy/hd.o] Error 1
> > 
> > <--  snip  -->
> > 
> > Reported-by: Adrian Bunk <bunk@kernel.org>
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> applied, thanks
> 
> BTW Could you look into converting your "remove BLK_DEV_HD_ONLY" patch
> into "move old hd driver to drivers/block/" one because the old hd driver
> still has some uses (as noticed by Alan)?

drivers/ide/Makefile says:
  # old hd driver must be last

Is this still true?

If yes then moving the driver to drivers/block/ requires switching to 
late_initcall() since drivers/block/ is linked before drivers/ide/ .

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/