Message-ID: <485EC1A1.1020503@linux.intel.com>
Date: Sun, 22 Jun 2008 14:18:25 -0700
From: Arjan van de Ven <arjan@linux.intel.com>
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
MIME-Version: 1.0
To: Vegard Nossum <vegard.nossum@gmail.com>
CC: a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] softirq softlockup debugging
References: <20080622122845.GA10133@damson.getinternet.no>
In-Reply-To: <20080622122845.GA10133@damson.getinternet.no>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1057
Lines: 29

Vegard Nossum wrote:

Hi

I like the general idea a lot; some comments below on the patch
> 
> diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> index f1fc747..97d47cf 100644
> --- a/include/linux/interrupt.h
> +++ b/include/linux/interrupt.h
> @@ -296,6 +296,9 @@ extern void softirq_init(void);
>  extern void raise_softirq_irqoff(unsigned int nr);
>  extern void raise_softirq(unsigned int nr);
>  
> +#ifdef CONFIG_SOFTLOCKUP_SOFTIRQ_DEBUG
> +extern void *get_last_softirq_action(int cpu);
> +#endif

you don't need to ifdef prototypes....
(there's only one exception: if the prototype uses types that are ifdef'd themselves, but that's not here)


In general... I don't like that this is a config option. I mean... is there a really strong
reason why this shouldn't just always be there?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/