Date: Mon, 23 Jun 2008 09:32:27 +0200
From: Andreas Herrmann <aherrman@arcor.de>
To: Tilman Schmidt <tilman@imap.cc>
Cc: Hansjoerg Lipp <hjlipp@web.de>, gigaset307x-common@lists.sourceforge.net,
       linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
       kkeil@suse.de
Subject: Re: [PATCH] gigaset: fix module reference counting
Message-ID: <20080623073227.GA6033@obelix>
References: <20080606223918.GA10348@kodscha> <4855A145.90803@imap.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4855A145.90803@imap.cc>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1397
Lines: 40

On Mon, Jun 16, 2008 at 01:09:57AM +0200, Tilman Schmidt wrote:
> On 2008-06-07 00:39, Andreas Herrmann wrote:
> > bas_gigaset can't be unloaded due to wrong module reference counting.
> > Ensure that module_put is called whenever a channel is freed.
> 
> I'm not quite happy with that patch. Specifically, I see a risk of
> module_put being called too often.

> Could you explain in some more detail what bug you are trying to fix?
> Do you have a sequence of events which leads to a situation where the
> bas_gigaset module cannot be unloaded but should be?

I've tried to reproduce the problem doing various tests -- but without
success.

Then i've checked the code and there was already this fix:

commit e468c04894f36045cf93d1384183a461014b6840 (Gigaset: permit module unload)

This was commited after 2.6.24 was released.

And (shit happens!) on the machine where I've previously tested the
stuff I had also an 2.6.24 kernel installed.

So it seems that I have mixed up different kernel versions when I've
tested my patch. Because with current git-tree bas_gigaset can be
unloaded without any problems.

Sorry for the noise.


Regards,

Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/