Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756945AbYFWJKM (ORCPT ); Mon, 23 Jun 2008 05:10:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753717AbYFWJJz (ORCPT ); Mon, 23 Jun 2008 05:09:55 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:58368 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753682AbYFWJJy (ORCPT ); Mon, 23 Jun 2008 05:09:54 -0400 Date: Mon, 23 Jun 2008 11:10:51 +0200 From: Pavel Machek To: "Chen, Huacai" Cc: linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org, lenb@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [linux-pm] [PATCH]ACPI: Fix CMOS time error after waking up by /proc/acpi/alarm Message-ID: <20080623091051.GA1917@elf.ucw.cz> References: <42DFA526FC41B1429CE7279EF83C6BDC0148CB4C@pdsmsx415.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC0148CB4C@pdsmsx415.ccr.corp.intel.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1352 Lines: 37 On Thu 2008-06-19 21:52:02, Chen, Huacai wrote: > From: Huacai Chen > > When writing /proc/acpi/alarm to wakeup up in adjust mode, this patch > read the "century" filed and add it to the "year" field before writing. > This avoids the CMOS time error (2000 years decrement) after waking up. > > Signed-off-by: Huacai Chen Probably word-wrapped, > --- > diff --git a/drivers/acpi/sleep/proc.c b/drivers/acpi/sleep/proc.c > index 224c57c..2a85783 100644 > --- a/drivers/acpi/sleep/proc.c > +++ b/drivers/acpi/sleep/proc.c > @@ -315,8 +315,11 @@ acpi_system_write_alarm(struct file *file, > cmos_bcd_write(day, acpi_gbl_FADT.day_alarm, > rtc_control); > if (acpi_gbl_FADT.month_alarm) > cmos_bcd_write(mo, acpi_gbl_FADT.month_alarm, > rtc_control); > - if (acpi_gbl_FADT.century) > + if (acpi_gbl_FADT.century){ and you definitely want ") {" here. It probably should go to Len and RTC maintainers? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/