Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754913AbYFWLNV (ORCPT ); Mon, 23 Jun 2008 07:13:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752711AbYFWLNK (ORCPT ); Mon, 23 Jun 2008 07:13:10 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:41823 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbYFWLNJ (ORCPT ); Mon, 23 Jun 2008 07:13:09 -0400 Date: Mon, 23 Jun 2008 13:12:38 +0200 From: Ingo Molnar To: Kevin Winchester Cc: Yinghai Lu , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Linux Kernel Mailing List , "Rafael J. Wysocki" , Pavel Machek Subject: Re: Bisecting tip/auto-x86-next? Message-ID: <20080623111238.GA7485@elte.hu> References: <20080620153626.GE17373@elte.hu> <485C4484.3080706@gmail.com> <86802c440806201714p271b7b3fx68183c5f48208bee@mail.gmail.com> <485CD12C.9080404@gmail.com> <86802c440806210318p23fc61bo709c0965254de72@mail.gmail.com> <86802c440806210330r25529b93u9c57734ad4fce58d@mail.gmail.com> <485CDA6A.103@gmail.com> <86802c440806210350y2f05999fme0eba7ca6aca201a@mail.gmail.com> <485CEAD9.10401@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <485CEAD9.10401@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2755 Lines: 78 * Kevin Winchester wrote: >> please try attached patch... > > Thanks for the patch. it fixes the problem for me. tip/master was > indeed showing the problem as well, but it does not once your patch is > applied. > > So you can add a: > > Tested-by: Kevin Winchester > > to the patch if you want. applied to tip/x86/gart - thanks a lot Kevin for bisecting this. I have attached the commit below. Ingo -----------------> commit 0754557d72c1fbfc5fcfd5235e7c23ae6f77248c Author: Yinghai Lu Date: Sat Jun 21 03:50:47 2008 -0700 x86: change early_gart_iommu_check() back to any_mapped Kevin Winchester reported a GART related direct rendering failure against linux-next-20080611, which shows up via these log entries: PCI: Using ACPI for IRQ routing PCI: Cannot allocate resource region 0 of device 0000:00:00.0 agpgart: Detected AGP bridge 0 agpgart: Aperture conflicts with PCI mapping. agpgart: Aperture from AGP @ e0000000 size 128 MB agpgart: Aperture conflicts with PCI mapping. agpgart: No usable aperture found. agpgart: Consider rebooting with iommu=memaper=2 to get a good aperture. instead of the expected: PCI: Using ACPI for IRQ routing agpgart: Detected AGP bridge 0 agpgart: Aperture from AGP @ e0000000 size 128 MB Kevin bisected it down to this change in tip/x86/gart: "x86: checking aperture size order". agp check is using request_mem_region(), and could fail if e820 is reserved... change it back to e820_any_mapped(). Reported-and-bisected-by: "Kevin Winchester" Signed-off-by: Yinghai Lu Tested-by: Kevin Winchester Signed-off-by: Ingo Molnar diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c index 3409abb..e819362 100644 --- a/arch/x86/kernel/aperture_64.c +++ b/arch/x86/kernel/aperture_64.c @@ -324,8 +324,8 @@ void __init early_gart_iommu_check(void) fix = 1; if (gart_fix_e820 && !fix && aper_enabled) { - if (!e820_all_mapped(aper_base, aper_base + aper_size, - E820_RESERVED)) { + if (e820_any_mapped(aper_base, aper_base + aper_size, + E820_RAM)) { /* reserve it, so we can reuse it in second kernel */ printk(KERN_INFO "update e820 for GART\n"); add_memory_region(aper_base, aper_size, E820_RESERVED); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/