Date: Mon, 23 Jun 2008 07:20:04 -0400
From: Christoph Hellwig <hch@infradead.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Deti Fliegl <deti@fliegl.de>,
       Mauro Carvalho Chehab <mchehab@infradead.org>,
       linux-kernel@vger.kernel.org, jaswinder@infradead.org
Subject: Re: [PATCH] dabusb: use request_firmware()
Message-ID: <20080623112004.GA26516@infradead.org>
References: <1214219201.27974.21.camel@shinybook.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1214219201.27974.21.camel@shinybook.infradead.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 942
Lines: 21

> +config USB_DABUSB_FIRMWARE
> +	bool "Include firmware images for DABUSB driver"
> +	depends on USB_DABUSB
> +	---help---
> +	Include the firmware for the DABUSB device in the kernel image.
> +	Say 'N' and let it get loaded from userspace.

Sorry if I missed a discussion on it in the intial firmware threads, but
what is the point of all these FOO_FIRMWARE options?  I think we should
include all firmware that we have a driver for if people want firmware
built-in and non if not.

That is instead of all these FOO_FIRMWARE options just have one
user-visible BUILTIN_FIRMWARE option.  Also makes it much less likely
for mingo to accidentally build a kernel image that doesn't actually boot :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/