Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760080AbYFWQJM (ORCPT ); Mon, 23 Jun 2008 12:09:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754848AbYFWQJA (ORCPT ); Mon, 23 Jun 2008 12:09:00 -0400 Received: from extu-mxob-1.symantec.com ([216.10.194.28]:47590 "EHLO extu-mxob-1.symantec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754771AbYFWQI7 (ORCPT ); Mon, 23 Jun 2008 12:08:59 -0400 Date: Mon, 23 Jun 2008 17:04:54 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@blonde.site To: Jeff Chua cc: Greg KH , Linus Torvalds , linux-kernel@vger.kernel.org, stable@kernel.org, Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , Willy Tarreau , Rodrigo Rubira Branco , akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Oleg Nesterov , Nick Piggin , KAMEZAWA Hiroyuki , Ingo Molnar , Roland McGrath Subject: Re: [patch 2/5] Reinstate ZERO_PAGE optimization in get_user_pages() and fix XIP In-Reply-To: Message-ID: References: <20080622185327.348377223@mini.kroah.org> <20080622190140.GD20141@suse.de> <20080622202950.GB20800@suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1520 Lines: 37 On Mon, 23 Jun 2008, Jeff Chua wrote: > On Mon, Jun 23, 2008 at 4:29 AM, Greg KH wrote: > > On Sun, Jun 22, 2008 at 12:22:47PM -0700, Linus Torvalds wrote: > >> Let's wait for the vmware breakage report to sort out first. > >> http://lkml.org/lkml/2008/6/22/10 > >> before moving it to -stable. > > > > Sure, thanks for pointing that out to me, I'll track it as well. > > I can confirm that the 2nd patch from Linus fixed the problem. > > http://lkml.org/lkml/2008/6/22/107 > > Sorry it took so long. Traveling. Long?! That was very quick, thanks for reporting back. But I'm afraid you've pushed me into taking another look at that patch, and I see a problem with it. To be honest, I've lost the plot on this issue, and didn't really get what your problem is, nor how Linus expected to be fixing it. The problem is that "insane" VM_LOCKED test which he has removed. I've remembered now what that's about: it's for make_pages_present. We do want mlocking a readonly area to make its pages present, even if they're not at this moment writable: we don't want the ZERO_PAGE substitution in that case. So I think Linus needs to factor that into the final patch, whilst at the same time solving whatever is the vmware breakage. Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/