Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755437AbYFWXr5 (ORCPT ); Mon, 23 Jun 2008 19:47:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751867AbYFWXrt (ORCPT ); Mon, 23 Jun 2008 19:47:49 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:49233 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254AbYFWXrt (ORCPT ); Mon, 23 Jun 2008 19:47:49 -0400 Date: Tue, 24 Jun 2008 01:47:28 +0200 From: Ingo Molnar To: Alok Kataria Cc: Arjan van de Ven , Thomas Gleixner , LKML , Daniel Hecht , Tim Mann , Zach Amsden , Sahil Rihan Subject: Re: [RFC PATCH] x86:Use cpu_khz for loops_per_jiffy calculation Message-ID: <20080623234728.GA17297@elte.hu> References: <1212540069.19290.57.camel@promb-2n-dhcp368.eng.vmware.com> <20080603182014.79a38d03@infradead.org> <35f686220806032101h103152dat841818982aaa5052@mail.gmail.com> <20080604061637.6bab3f67@infradead.org> <1213924953.27983.52.camel@promb-2n-dhcp368.eng.vmware.com> <20080620113922.GG7439@elte.hu> <1213999593.31598.52.camel@promb-2n-dhcp368.eng.vmware.com> <20080623232149.GA22926@elte.hu> <1214264070.3882.22.camel@promb-2n-dhcp368.eng.vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1214264070.3882.22.camel@promb-2n-dhcp368.eng.vmware.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 25 * Alok Kataria wrote: > > but there's another problem as well: why are generic files > > (init/calibrate.c and include/linux/delay.h) using something that is > > named in an x86-specific way - lpj_tsc ? (TSC is an x86 concept) > > calibrate_delay_direct was using some variables with "tsc" as the > prefix (tsc_rate_min/max) ...so i thought of using lpj_tsc. And also > IMO, lpj_tsc explains how is this variable initialized. But thinking > about it, maybe we should rename it to "lpj_timer" ? ok. But instead of 'lpj_timer' i'd suggest to use something like 'lpj_fine' - as this really is about finegrained measurements. I'd suggest a delta patch against tip/master that renames all those tsc_* variables to fine_*. So tsc_rate_min would become fine_rate_min, etc. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/