Date: Tue, 24 Jun 2008 13:08:21 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
       linux-kernel@vger.kernel.org,
       Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
       Suresh B Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH 0/7] x86: pat.c: reserve_memtype strip down
Message-ID: <20080624110820.GB8695@elte.hu>
References: <20080620195503.GB4105@alberich.amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080620195503.GB4105@alberich.amd.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 917
Lines: 29


* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:

> This patch set will (first of all) cleanup reserve_memtype a little 
> bit to make it easier to read and maintain.
> 
> (... and hopefully it doesn't break anything.;-)

applied to tip/x86/pat - thanks Andreas.

> Instead of sending one large patch I broke it down into several pieces 
> to make it easier to review.

thanks!

A nice splitup not only makes review easier but in the (i know, very 
unlikely ;-) case of breakage it narrows down the problem change. 

It also makes maintenance and integration easier.

Especially for architecture code it is very important to do as small 
changes as possible.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/