Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755609AbYFXTsT (ORCPT ); Tue, 24 Jun 2008 15:48:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752489AbYFXTsK (ORCPT ); Tue, 24 Jun 2008 15:48:10 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:34729 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbYFXTsJ (ORCPT ); Tue, 24 Jun 2008 15:48:09 -0400 Date: Tue, 24 Jun 2008 12:47:27 -0700 (PDT) From: Linus Torvalds To: Miklos Szeredi cc: jens.axboe@oracle.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [rfc patch 3/4] splice: remove confirm from pipe_buf_operations In-Reply-To: Message-ID: References: <20080621154607.154640724@szeredi.hu> <20080621154726.494538562@szeredi.hu> <20080624080440.GJ20851@kernel.dk> <20080624111913.GP20851@kernel.dk> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 19 On Tue, 24 Jun 2008, Miklos Szeredi wrote: > > Or it can only happen if there was an I/O error on reading the page. Now, IO errors are something else. They should have the PG_error bit set, and we should just return EIO or something. That said, I'd not be surprised at all if error handling is broken. It's often been broken even in the _normal_ paths (ie totally normal "read()" etc). Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/